amahussein commented on pull request #2581: URL: https://github.com/apache/hadoop/pull/2581#issuecomment-756136730
> Thank for working on this, @amahussein. LGTM overall pending some nits. > > While it is too late here, it is hard to follow which part of the TestDistributedShell is modified if splitting the class and refactoring are mixed up in a single commit. Doing one thing in one PR makes reviewing and cherry-picking easier. Thanks for the review @iwasakims and @goiri ! Just quick point. Can you please use "start review" feature instead of sending separate comments? single comments do not indicate whether the reviewer is done with his reviews or not. Therefore, I could start a new commit before receiving all the feedback. Thanks again guys. I understand that the PR was not straightforward to review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
