[ 
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=539064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539064
 ]

ASF GitHub Bot logged work on HADOOP-17483:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jan/21 13:57
            Start Date: 21/Jan/21 13:57
    Worklog Time Spent: 10m 
      Work Description: steveloughran opened a new pull request #2637:
URL: https://github.com/apache/hadoop/pull/2637


   
   
   #2636 updated the docs; this is the code-side change to remove the option of 
disabling magic committer support in the FS
   
   That was a safety check to stop people enabling it on inconsistent/unguarded 
buckets. We can stop worrying there.
   
   Before anyone asks: what about inconsistent third party stores: every one 
else's has always been consistent.
   
   tested: s3 london with `-Dparallel-tests -DtestsThreadCount=6 
-Dmarkers=delete -Dtest=no -Dfs.s3a.directory.marker.audit=true -Dscale`
   
   Looks like I skipped the unit tests there...lets see what yetus says


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 539064)
    Remaining Estimate: 0h
            Time Spent: 10m

> magic committer to be enabled for all S3 buckets
> ------------------------------------------------
>
>                 Key: HADOOP-17483
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17483
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> now that S3 is consistent, there is no need to disable the magic committer 
> for safety.
> remove option to enable magic committer (fs.s3a.committer.magic.enabled) and 
> the associated checks/probes through the code.
> May want to retain the constants and probes just for completeness/API/CLI 
> consistency. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to