[
https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=541059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541059
]
ASF GitHub Bot logged work on HADOOP-17483:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/21 13:16
Start Date: 25/Jan/21 13:16
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#2637:
URL: https://github.com/apache/hadoop/pull/2637#discussion_r563714057
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/MagicCommitIntegration.java
##########
@@ -128,17 +126,15 @@ public PutTracker createTracker(Path path, String key) {
* @return a list of elements, possibly empty
*/
private List<String> finalDestination(List<String> elements) {
- return magicCommitEnabled ?
- MagicCommitPaths.finalDestination(elements)
- : elements;
+ return MagicCommitPaths.finalDestination(elements);
}
/**
* Is magic commit enabled?
* @return true if magic commit is turned on.
*/
public boolean isMagicCommitEnabled() {
- return magicCommitEnabled;
+ return true;
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 541059)
Time Spent: 1h (was: 50m)
> magic committer to be enabled for all S3 buckets
> ------------------------------------------------
>
> Key: HADOOP-17483
> URL: https://issues.apache.org/jira/browse/HADOOP-17483
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> now that S3 is consistent, there is no need to disable the magic committer
> for safety.
> remove option to enable magic committer (fs.s3a.committer.magic.enabled) and
> the associated checks/probes through the code.
> May want to retain the constants and probes just for completeness/API/CLI
> consistency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
