[
https://issues.apache.org/jira/browse/HADOOP-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269665#comment-17269665
]
Jim Brennan commented on HADOOP-17485:
--------------------------------------
I would recommend minimizing the changes needed to pull back this change and
fix any unit tests that are broken by it and convert any lambdas. The
LDAPGroupMapping changes are needed as part of the port, I think.
Fixing up the deprecated call sites should definitely be done in trunk first -
I would be ok with ignoring those warnings for this and filing a new Jira to
fix those, since they are the same as what is in trunk. The guava replacement
could probably be lumped with that.
I'm not sure I like changing to LinkedHashSet just to make it easier to fix
some tests. Why don't those tests fail in trunk?
IIUC, pulling this back without HADOOP-17467 will break things in 2.10, so
we'll need to make sure that fix is done in trunk before doing this so both can
be pulled back together. Is that correct?
> port UGI#getGroupsSet optimizations into 2.10
> ---------------------------------------------
>
> Key: HADOOP-17485
> URL: https://issues.apache.org/jira/browse/HADOOP-17485
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HADOOP-17079 introduced an optimization adding a UGI#getGroupsSet and use
> Set#contains() instead of List#contains() to speed up large group look up
> while minimize List->Set conversions in Groups#getGroups() call.
> This ticket is to port the changes into branch-2.10.
>
> CC: [~Jim_Brennan], [~xyao]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
