[ 
https://issues.apache.org/jira/browse/HADOOP-17485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270223#comment-17270223
 ] 

Ahmed Hussein commented on HADOOP-17485:
----------------------------------------

The changes needed to cherry-pick HADOOP-17079:
 * conflicts of files in imports: Those were trivial fixes
 * Some classes do not exist in 2.10. So those files were left out.
 * Two files had major incompatibility: {{UserGroupMappingPlacementRule}} and 
{{LdapGroupsMapping}}.
 ** For those two files I manually replaced {{getGroups()}} with 
{{getGroupSet()}}.
 ** In the version committed to trunk 
[f91a8ad|[https://github.com/apache/hadoop/commit/f91a8ad88b00b50231f1ae3f8820a25c963bb561#diff-34cbaed59eb28984bdb38185b850527c6bc2088d2295fee6657333084aeab668R670],
 I found that {{getGroupSet()}} is not "synchronized", while {{getGroups()}} is 
synchronized.

> port UGI#getGroupsSet optimizations into 2.10
> ---------------------------------------------
>
>                 Key: HADOOP-17485
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17485
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> HADOOP-17079 introduced an optimization adding a UGI#getGroupsSet and use 
> Set#contains() instead of List#contains() to speed up large group look up 
> while minimize List->Set conversions in Groups#getGroups() call.
> This ticket is to port the changes into branch-2.10.
>  
> CC: [~Jim_Brennan], [~xyao]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to