[ 
https://issues.apache.org/jira/browse/HADOOP-17485?focusedWorklogId=539405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539405
 ]

ASF GitHub Bot logged work on HADOOP-17485:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jan/21 00:42
            Start Date: 22/Jan/21 00:42
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-765034981


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  11m 46s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
19 new or modified test files.  |
   ||| _ branch-2.10 Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  14m 26s |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |  13m 10s |  branch-2.10 passed  |
   | +1 :green_heart: |  checkstyle  |   2m 21s |  branch-2.10 passed  |
   | +1 :green_heart: |  mvnsite  |   6m 44s |  branch-2.10 passed  |
   | +1 :green_heart: |  javadoc  |   5m 30s |  branch-2.10 passed  |
   | +0 :ok: |  spotbugs  |   2m  0s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  10m 55s |  branch-2.10 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 30s |  the patch passed  |
   | +1 :green_heart: |  compile  |  12m 30s |  the patch passed  |
   | -1 :x: |  javac  |  12m 30s |  root generated 1 new + 1541 unchanged - 0 
fixed = 1542 total (was 1541)  |
   | -0 :warning: |  checkstyle  |   2m 25s |  root: The patch generated 2 new 
+ 1197 unchanged - 16 fixed = 1199 total (was 1213)  |
   | +1 :green_heart: |  mvnsite  |   6m 34s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 1 line(s) that end in 
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  javadoc  |   5m 32s |  the patch passed  |
   | -1 :x: |  findbugs  |   2m 41s |  hadoop-common-project/hadoop-common 
generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   9m 14s |  hadoop-common in the patch failed.  |
   | -1 :x: |  unit  |  65m 18s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  unit  |   5m  3s |  hadoop-hdfs-httpfs in the patch 
passed.  |
   | -1 :x: |  unit  |  18m 15s |  hadoop-hdfs-rbf in the patch failed.  |
   | -1 :x: |  unit  |  67m 48s |  hadoop-yarn-server-resourcemanager in the 
patch failed.  |
   | +1 :green_heart: |  unit  |   4m 37s |  hadoop-mapreduce-client-hs in the 
patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  0s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 290m 12s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-common-project/hadoop-common |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time  
Unsynchronized access at LdapGroupsMapping.java:75% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 630] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time  
Unsynchronized access at LdapGroupsMapping.java:50% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 629] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.conf; locked 50% of time  
Unsynchronized access at LdapGroupsMapping.java:50% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 632] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.groupHierarchyLevels; locked 50% 
of time  Unsynchronized access at LdapGroupsMapping.java:50% of time  
Unsynchronized access at LdapGroupsMapping.java:[line 340] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.groupNameAttr; locked 50% of time  
Unsynchronized access at LdapGroupsMapping.java:50% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 533] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.ldapCxtFactoryClass; locked 50% of 
time  Unsynchronized access at LdapGroupsMapping.java:50% of time  
Unsynchronized access at LdapGroupsMapping.java:[line 613] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.ldapUrls; locked 50% of time  
Unsynchronized access at LdapGroupsMapping.java:50% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 750] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.memberOfAttr; locked 60% of time  
Unsynchronized access at LdapGroupsMapping.java:60% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 503] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.numAttemptsBeforeFailover; locked 
50% of time  Unsynchronized access at LdapGroupsMapping.java:50% of time  
Unsynchronized access at LdapGroupsMapping.java:[line 346] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.posixGidAttr; locked 50% of time  
Unsynchronized access at LdapGroupsMapping.java:50% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 398] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.posixUidAttr; locked 60% of time  
Unsynchronized access at LdapGroupsMapping.java:60% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 399] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.useOneQuery; locked 66% of time  
Unsynchronized access at LdapGroupsMapping.java:66% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 496] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.useSsl; locked 66% of time  
Unsynchronized access at LdapGroupsMapping.java:66% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 618] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.userSearchFilter; locked 66% of 
time  Unsynchronized access at LdapGroupsMapping.java:66% of time  
Unsynchronized access at LdapGroupsMapping.java:[line 485] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.userbaseDN; locked 66% of time  
Unsynchronized access at LdapGroupsMapping.java:66% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 485] |
   | Failed junit tests | hadoop.security.TestGroupsCaching |
   |   | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
   |   | 
hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain |
   |   | hadoop.hdfs.server.federation.router.TestRouterQuota |
   |   | hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat |
   |   | hadoop.hdfs.server.federation.resolver.order.TestLocalResolver |
   |   | hadoop.hdfs.server.federation.resolver.TestMultipleDestinationResolver 
|
   |   | hadoop.yarn.server.resourcemanager.TestClientRMService |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux da51df9ebb6b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-2.10 / e48b91c |
   | Default Java | Oracle Corporation-1.7.0_95-b00 |
   | javac | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/diff-compile-javac-root.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/diff-checkstyle-root.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/whitespace-eol.txt
 |
   | findbugs | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/testReport/ |
   | Max. process+thread count | 2452 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs 
hadoop-hdfs-project/hadoop-hdfs-rbf 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: 
. |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/3/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 539405)
    Time Spent: 20m  (was: 10m)

> port UGI#getGroupsSet optimizations into 2.10
> ---------------------------------------------
>
>                 Key: HADOOP-17485
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17485
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> HADOOP-17079 introduced an optimization adding a UGI#getGroupsSet and use 
> Set#contains() instead of List#contains() to speed up large group look up 
> while minimize List->Set conversions in Groups#getGroups() call.
> This ticket is to port the changes into branch-2.10.
>  
> CC: [~Jim_Brennan], [~xyao]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to