[ 
https://issues.apache.org/jira/browse/HADOOP-17485?focusedWorklogId=540110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-540110
 ]

ASF GitHub Bot logged work on HADOOP-17485:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jan/21 10:58
            Start Date: 22/Jan/21 10:58
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #2631:
URL: https://github.com/apache/hadoop/pull/2631#issuecomment-765322542


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  11m 32s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
12 new or modified test files.  |
   ||| _ branch-2.10 Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  15m  4s |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |  13m 39s |  branch-2.10 passed  |
   | +1 :green_heart: |  checkstyle  |   2m 18s |  branch-2.10 passed  |
   | +1 :green_heart: |  mvnsite  |   6m 30s |  branch-2.10 passed  |
   | +1 :green_heart: |  javadoc  |   5m  9s |  branch-2.10 passed  |
   | +0 :ok: |  spotbugs  |   2m  3s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  11m 42s |  branch-2.10 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 45s |  the patch passed  |
   | +1 :green_heart: |  compile  |  12m 53s |  the patch passed  |
   | -1 :x: |  javac  |  12m 53s |  root generated 79 new + 1531 unchanged - 3 
fixed = 1610 total (was 1534)  |
   | +1 :green_heart: |  checkstyle  |   2m 17s |  root: The patch generated 0 
new + 983 unchanged - 8 fixed = 983 total (was 991)  |
   | +1 :green_heart: |  mvnsite  |   6m 16s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   5m 19s |  the patch passed  |
   | -1 :x: |  findbugs  |   2m 46s |  hadoop-common-project/hadoop-common 
generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  10m  3s |  hadoop-common in the patch passed. 
 |
   | -1 :x: |  unit  |  68m 53s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  unit  |   4m 51s |  hadoop-hdfs-httpfs in the patch 
passed.  |
   | -1 :x: |  unit  |  18m 23s |  hadoop-hdfs-rbf in the patch failed.  |
   | -1 :x: |  unit  |  70m 52s |  hadoop-yarn-server-resourcemanager in the 
patch failed.  |
   | +1 :green_heart: |  unit  |   4m 37s |  hadoop-mapreduce-client-hs in the 
patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 58s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 298m 40s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-common-project/hadoop-common |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time  
Unsynchronized access at LdapGroupsMapping.java:75% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 596] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time  
Unsynchronized access at LdapGroupsMapping.java:50% of time  Unsynchronized 
access at LdapGroupsMapping.java:[line 595] |
   | Failed junit tests | 
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
   |   | 
hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain |
   |   | hadoop.hdfs.server.federation.resolver.TestMultipleDestinationResolver 
|
   |   | hadoop.hdfs.server.federation.resolver.order.TestLocalResolver |
   |   | hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat |
   |   | hadoop.hdfs.server.federation.router.TestRouterQuota |
   |   | hadoop.yarn.server.resourcemanager.TestClientRMService |
   |   | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer 
|
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2631 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 5403b5396972 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-2.10 / e48b91c |
   | Default Java | Oracle Corporation-1.7.0_95-b00 |
   | javac | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/diff-compile-javac-root.txt
 |
   | findbugs | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/testReport/ |
   | Max. process+thread count | 2633 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs 
hadoop-hdfs-project/hadoop-hdfs-rbf 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: 
. |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2631/4/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 540110)
    Time Spent: 0.5h  (was: 20m)

> port UGI#getGroupsSet optimizations into 2.10
> ---------------------------------------------
>
>                 Key: HADOOP-17485
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17485
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> HADOOP-17079 introduced an optimization adding a UGI#getGroupsSet and use 
> Set#contains() instead of List#contains() to speed up large group look up 
> while minimize List->Set conversions in Groups#getGroups() call.
> This ticket is to port the changes into branch-2.10.
>  
> CC: [~Jim_Brennan], [~xyao]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to