[
https://issues.apache.org/jira/browse/HADOOP-17424?focusedWorklogId=543157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543157
]
ASF GitHub Bot logged work on HADOOP-17424:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 22:44
Start Date: 27/Jan/21 22:44
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2645:
URL: https://github.com/apache/hadoop/pull/2645#issuecomment-768627815
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 28m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | | No case conflicting files
found. |
| +0 :ok: | buf | 0m 1s | | buf was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | | 0m 0s | [test4tests](test4tests) | The patch
appears to include 8 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 7s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 23m 29s | | trunk passed |
| +1 :green_heart: | compile | 22m 23s | | trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 9s | | trunk passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +1 :green_heart: | checkstyle | 4m 21s | | trunk passed |
| +1 :green_heart: | mvnsite | 6m 52s | | trunk passed |
| +1 :green_heart: | shadedclient | 27m 38s | | branch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 5m 30s | | trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 6m 24s | | trunk passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +0 :ok: | spotbugs | 0m 28s | | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 30s | | branch/hadoop-project no findbugs
output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 28s | |
branch/hadoop-client-modules/hadoop-client-api no findbugs output file
(findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 28s | |
branch/hadoop-client-modules/hadoop-client-runtime no findbugs output file
(findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 26s | |
branch/hadoop-client-modules/hadoop-client-check-invariants no findbugs output
file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 28s | |
branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file
(findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 28s | |
branch/hadoop-client-modules/hadoop-client-check-test-invariants no findbugs
output file (findbugsXml.xml) |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 15m 6s | | the patch passed |
| +1 :green_heart: | compile | 21m 42s | | the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| -1 :x: | cc | 21m 42s |
[/diff-compile-cc-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.txt)
| root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 generated 36 new + 376 unchanged - 36
fixed = 412 total (was 412) |
| +1 :green_heart: | javac | 21m 42s | | the patch passed |
| +1 :green_heart: | compile | 19m 4s | | the patch passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| -1 :x: | cc | 19m 4s |
[/diff-compile-cc-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt)
| root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 generated 31 new + 381
unchanged - 31 fixed = 412 total (was 412) |
| +1 :green_heart: | javac | 19m 4s | | the patch passed |
| -0 :warning: | checkstyle | 4m 19s |
[/diff-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/artifact/out/diff-checkstyle-root.txt)
| root: The patch generated 8 new + 1316 unchanged - 41 fixed = 1324 total
(was 1357) |
| +1 :green_heart: | mvnsite | 6m 51s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no
whitespace issues. |
| +1 :green_heart: | xml | 0m 9s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | shadedclient | 15m 39s | | patch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 5m 27s | | the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 6m 23s | | the patch passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| +0 :ok: | findbugs | 0m 26s | | hadoop-project has no data from
findbugs |
| -1 :x: | findbugs | 2m 29s |
[/new-findbugs-hadoop-common-project_hadoop-common.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html)
| hadoop-common-project/hadoop-common generated 9 new + 0 unchanged - 0 fixed
= 9 total (was 0) |
| -1 :x: | findbugs | 2m 47s |
[/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html)
| hadoop-hdfs-project/hadoop-hdfs-client generated 3 new + 0 unchanged - 0
fixed = 3 total (was 0) |
| +0 :ok: | findbugs | 0m 26s | |
hadoop-client-modules/hadoop-client-api has no data from findbugs |
| +0 :ok: | findbugs | 0m 28s | |
hadoop-client-modules/hadoop-client-runtime has no data from findbugs |
| +0 :ok: | findbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-check-invariants has no data from findbugs
|
| +0 :ok: | findbugs | 0m 27s | |
hadoop-client-modules/hadoop-client-minicluster has no data from findbugs |
| +0 :ok: | findbugs | 0m 29s | |
hadoop-client-modules/hadoop-client-check-test-invariants has no data from
findbugs |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 26s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 17m 3s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 2m 24s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | unit | 224m 18s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 0m 36s | | hadoop-client-api in the patch
passed. |
| +1 :green_heart: | unit | 0m 33s | | hadoop-client-runtime in the
patch passed. |
| +1 :green_heart: | unit | 0m 33s | | hadoop-client-check-invariants
in the patch passed. |
| +1 :green_heart: | unit | 0m 36s | | hadoop-client-minicluster in
the patch passed. |
| +1 :green_heart: | unit | 0m 33s | |
hadoop-client-check-test-invariants in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | | The patch does not
generate ASF License warnings. |
| | | 517m 36s | | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addKVAnnotation(String, String) ignored,
but method has no side effect At FileSystem.java:ignored, but method has no
side effect At FileSystem.java:[line 3465] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addKVAnnotation(String, String) ignored,
but method has no side effect At Globber.java:ignored, but method has no side
effect At Globber.java:[line 199] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addTimelineAnnotation(String) ignored, but
method has no side effect At ProtobufRpcEngine.java:but method has no side
effect At ProtobufRpcEngine.java:[line 251] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addTimelineAnnotation(String) ignored, but
method has no side effect At ProtobufRpcEngine2.java:but method has no side
effect At ProtobufRpcEngine2.java:[line 245] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addTimelineAnnotation(String) ignored, but
method has no side effect At Server.java:but method has no side effect At
Server.java:[line 2980] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addKVAnnotation(String, String) ignored,
but method has no side effect At Groups.java:ignored, but method has no side
effect At Groups.java:[line 349] |
| | Unwritten public or protected
field:org.apache.hadoop.tracing.Span.spanContext At Span.java:[line 37] |
| | Write to static field org.apache.hadoop.tracing.Tracer.globalTracer
from instance method new org.apache.hadoop.tracing.Tracer() At
Tracer.java:from instance method new org.apache.hadoop.tracing.Tracer() At
Tracer.java:[line 28] |
| | Unread field:Tracer.java:[line 75] |
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs-client |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addKVAnnotation(String, String) ignored,
but method has no side effect At DFSClient.java:ignored, but method has no
side effect At DFSClient.java:[line 3213] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addKVAnnotation(String, String) ignored,
but method has no side effect At DFSClient.java:ignored, but method has no
side effect At DFSClient.java:[line 3221] |
| | Return value of
org.apache.hadoop.tracing.TraceScope.addKVAnnotation(String, Number) ignored,
but method has no side effect At DFSOutputStream.java:ignored, but method has
no side effect At DFSOutputStream.java:[line 999] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2645 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle cc buflint bufcompat |
| uname | Linux e97c06b456c2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 80c7404b519 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/testReport/ |
| Max. process+thread count | 2297 (vs. ulimit of 5500) |
| modules | C: hadoop-project hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs
hadoop-client-modules/hadoop-client-api
hadoop-client-modules/hadoop-client-runtime
hadoop-client-modules/hadoop-client-check-invariants
hadoop-client-modules/hadoop-client-minicluster
hadoop-client-modules/hadoop-client-check-test-invariants U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2645/3/console |
| versions | git=2.25.1 maven=3.6.3 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543157)
Time Spent: 6h 20m (was: 6h 10m)
> Replace HTrace with No-Op tracer
> --------------------------------
>
> Key: HADOOP-17424
> URL: https://issues.apache.org/jira/browse/HADOOP-17424
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Remove HTrace dependency as it is depending on old jackson jars. Use a no-op
> tracer for now to eliminate potential security issues.
> The plan is to move part of the code in
> [PR#1846|https://github.com/apache/hadoop/pull/1846] out here for faster
> review.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
