[
https://issues.apache.org/jira/browse/HADOOP-17424?focusedWorklogId=544068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544068
]
ASF GitHub Bot logged work on HADOOP-17424:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/21 06:59
Start Date: 29/Jan/21 06:59
Worklog Time Spent: 10m
Work Description: Sushmasree-28 commented on pull request #2645:
URL: https://github.com/apache/hadoop/pull/2645#issuecomment-769619267
> > @smengcl @iwasakims Thank you for the work here
> > I have taken your latest patch, compiled and trying to verify trace
feature.
> > Just wanted to confirm, As per the PR, TraceAdminProtocols have been
removed. Will these TraceAdminProtocol be handled in any follow-up JIRAs or
will be removed permanently ?
>
> Hi @Sushmasree-28 , thanks for taking your time to check this PR.
>
> The current plan it to ditch the `TraceAdminProtocol` **completely**. As I
previously (tentatively) implemented OpenTracing in #1846 , I don't find the
legacy interface useful anymore (unless we want to maintain compatibility with
HTrace -- which has become a potential security hazard -- and hence this PR).
So I would just remove it here. Let me know if you have more concerns about it.
@smengcl , OK, thanks for the update regarding TraceAdminProtocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 544068)
Time Spent: 6h 40m (was: 6.5h)
> Replace HTrace with No-Op tracer
> --------------------------------
>
> Key: HADOOP-17424
> URL: https://issues.apache.org/jira/browse/HADOOP-17424
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Remove HTrace dependency as it is depending on old jackson jars. Use a no-op
> tracer for now to eliminate potential security issues.
> The plan is to move part of the code in
> [PR#1846|https://github.com/apache/hadoop/pull/1846] out here for faster
> review.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
