GauthamBanasandra commented on pull request #2567: URL: https://github.com/apache/hadoop/pull/2567#issuecomment-770167068
@iwasakims the crux of my PR was to replace Linux specific code with a cross platform equivalent API so that Hadoop can run natively on all platforms. I've implemented the functionality of `basename` using a cross platform implementation supported by the C++17 standard in `std::filesystem`. So, it shouldn't really cause any platform specific issues. May I know what Linux specific complications you're referring to, that my PR doesn't address? I would be happy to address them in a way that's cross-platform friendly. 😊 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
