GauthamBanasandra commented on pull request #2567: URL: https://github.com/apache/hadoop/pull/2567#issuecomment-770238293
> Just making basename portable is not worth for the hustle Actually @iwasakims , I'll be replacing _all_ the Linux specific code in my further PRs. So, this upgrade to Focal serves as a foundation for my further PRs and isn't only for basename. > How about just implementint the basename It isn't straightforward to do so. Also, it'll be error prone. I would rather rely on the implementation provided by C++17 standard library. I'm sure the C++ library authors write better code than me. 😁 > gcc and cmake provided as OS standard package has been able to be used on distro such as CentOS 7 and 8, Debian 9 and 10 Ubuntu 16.04 and 18.04 befor this PR. We need to install gcc and cmake from source code or supplement package (if available) on most of those distros now. Well, sooner or later, somebody would've upgraded to Focal and this would've been a problem anyway. I'm sure this was a problem at the time when the move from Xenial to Bionic happened. I'm not sure if it's any different now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
