steveloughran commented on pull request #2675: URL: https://github.com/apache/hadoop/pull/2675#issuecomment-774112977
HADOOP-15711. Auditing: scope/coverage running all the tests with auditing set to fail if any call is made unaudited highlights scope for improvement. Production * Critical: nested scopes * Committers: scoping * S3GuardTool spans around lower-level operations. * Multipart listing to become a spanned entry point. Test * create spans before all tests doing low-level things ## Still a WiP, needs * new tests for new code * full coverage * stability on http referrer format. Even if doesn't yet use opentelemetry, I'd like compatible names/structure +thinking of seeing how to push in telemetry prepareRequest() into AWS SDK logic so all SDK calls have span checking/header addition, and production code would actually be slightly leaner. Needs me to understand the SDK a bit better, then for the audit manager to use an appropriate plugin point in the SDK to hand off to the active audit for preparation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
