steveloughran commented on a change in pull request #2675:
URL: https://github.com/apache/hadoop/pull/2675#discussion_r577084215
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -4532,8 +4814,10 @@ private HeaderProcessing getHeaderProcessing() {
public RemoteIterator<LocatedFileStatus> listLocatedStatus(final Path f,
final PathFilter filter)
throws FileNotFoundException, IOException {
- entryPoint(INVOCATION_LIST_LOCATED_STATUS);
Path path = qualify(f);
+ // Unless that iterator is closed, the iterator wouldn't be closed
+ // there.
+ entryPoint(INVOCATION_LIST_LOCATED_STATUS, path);
Review comment:
I try to explain it above. The iterator is picking it up. We do the same
for all ops which return something (listing, input stream, output stream...)
which outlives the API. The audit span goes with the object and so is left
open. Listings are a troublespot as they are unlikely ever to be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
