functioner commented on pull request #2727: URL: https://github.com/apache/hadoop/pull/2727#issuecomment-788624136
> @functioner Just update the value of `CommonConfigurationKeys.IPC_CLIENT_RPC_TIMEOUT_DEFAULT` and core-default.xml if you want to change the default timeout. "ipc.client.rpc-timeout.ms=0" should mean "no timeout". @iwasakims Thanks for your explanation. Now I understand your design. I agree that we should avoid modifying Client.java in order to avoid bringing new bug. I also agree that "ipc.client.rpc-timeout.ms=0" should mean "no timeout". I think we should update the description for `ipc.client.rpc-timeout.ms`, to specify that "ipc.client.rpc-timeout.ms=0" means no timeout. Otherwise the users might get confused. For example, if they set `ipc.client.ping` as true and `ipc.client.rpc-timeout.ms` as 0, they would think the rpcTimeout is pingInterval. https://github.com/apache/hadoop/blob/1f1a1ef52df896a2b66b16f5bbc17aa39b1a1dd7/hadoop-common-project/hadoop-common/src/main/resources/core-default.xml#L2384-L2392 For the default value of `ipc.client.rpc-timeout.ms`, I think 0 is okay, as long as we make the description of `ipc.client.rpc-timeout.ms` clear. @iwasakims I'm going to update the description of `ipc.client.rpc-timeout.ms` to eliminate the confusion, without modifying any Java code. Do you agree? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
