functioner commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-806219473
Thanks @Hexiaoqiao for your review. I have added the multi-threaded executor for it. For the exception handling part, I observe the original semantics of `RpcEdit` https://github.com/apache/hadoop/blob/aaedc51d8783c2808563d5c8b51b68ab79e19820/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L379-L387 and `SyncEdit` https://github.com/apache/hadoop/blob/aaedc51d8783c2808563d5c8b51b68ab79e19820/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L347-L353 Therefore, we don't need to add any extra handling mechanism. I have checked the test of `TestEditLogRace` and `TestEditLog` in my local machine. It passes all the tests. Let's see if there are other tests that fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
