functioner commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-806363752
> @functioner would you mind to add unit test to cover this improvement? I'm writing a unit test to cover this improvement. After I read the test cases of `TestEditLog` and `TestEditLogRace`, I think we can try to add a test similar to `TestEditLogRace#testDeadlock`. My current design is basically adding an `Edit` which intentionally sleeps for a while in its `logSyncNotify` method, blocking the next `Edit`, and test if the next `Edit` can finish soon. However, if we use this design, the test needs to access some private methods and classes in `FSEditLogAsync`. I think maybe it's not a good idea to change some modifiers in `FSEditLogAsync`. Can we use something like `@exposeToTest`? (sorry that I don't have experience in this part). Or can you come up with a better design? @Hexiaoqiao @jojochuang @ayushtkn @linyiqun Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
