kishendas commented on a change in pull request #2949:
URL: https://github.com/apache/hadoop/pull/2949#discussion_r622460440
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
##########
@@ -730,6 +732,33 @@ public void testSerializationAvailability() throws
IOException {
}
}
+ @Test
+ public void testSequenceFileWriter() throws Exception {
+ FileSystem fs = FileSystem.getLocal(conf);
+ Path p = new Path(GenericTestUtils.getTempPath("testCreateUsesFSArg.seq"));
+ FSDataOutputStream out = fs.create(p);
+ FSDataOutputStream spyOut = Mockito.spy(out);
+ SequenceFile.Writer writer = SequenceFile.createWriter(
+ fs, conf, p, NullWritable.class, NullWritable.class);
+
+ writer.setOutputStream(spyOut);
+ writer.flush();
+ writer.hflush();
+ writer.hasCapability(StreamCapabilities.HFLUSH);
+ Mockito.verify(spyOut, times(1)).hflush();
+ Mockito.verify(spyOut, times(1)).flush();
+ Mockito.verify(spyOut, times(1)).hasCapability(StreamCapabilities.HFLUSH);
+
+ writer.setOutputStream(null);
+
+ // below statements should not throw NullPointerException, although output
stream is null
+ writer.flush();
+ writer.hflush();
+ Assert.assertFalse(writer.hasCapability(StreamCapabilities.HFLUSH));
+
+ writer.close();
Review comment:
Done
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
##########
@@ -1051,6 +1051,11 @@ public static Option compression(CompressionType value,
return new CompressionOption(value, codec);
}
+
@org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting
Review comment:
Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
