steveloughran commented on pull request #2949:
URL: https://github.com/apache/hadoop/pull/2949#issuecomment-829134626
I do like the new test, now there's just the little detail that it's not
quite working yet
```
[INFO] Running org.apache.hadoop.io.TestSequenceFile
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
9.818 s <<< FAILURE! - in org.apache.hadoop.io.TestSequenceFile
[ERROR] testSequenceFileWriter(org.apache.hadoop.io.TestSequenceFile) Time
elapsed: 0.614 s <<< ERROR!
java.io.IOException: wrong key class: org.apache.hadoop.io.LongWritable is
not class org.apache.hadoop.io.NullWritable
at
org.apache.hadoop.io.SequenceFile$RecordCompressWriter.append(SequenceFile.java:1508)
at
org.apache.hadoop.io.SequenceFile$Writer.append(SequenceFile.java:1425)
at
org.apache.hadoop.io.TestSequenceFile.testSequenceFileWriter(TestSequenceFile.java:745)
```
+ minor checkstyles
```
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java:737:
Path p = new
Path(GenericTestUtils.getTempPath("testSequenceFileWriter.seq"));: Line is
longer than 80 characters (found 82). [LineLength]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java:745:
writer.append(key,value);:24: ',' is not followed by whitespace.
[WhitespaceAfter]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
