[
https://issues.apache.org/jira/browse/HADOOP-17680?focusedWorklogId=594898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594898
]
ASF GitHub Bot logged work on HADOOP-17680:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/21 23:35
Start Date: 11/May/21 23:35
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2999:
URL: https://github.com/apache/hadoop/pull/2999#issuecomment-839284392
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 14m 53s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ branch-2.10 Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 50s | branch-2.10 passed |
| +1 :green_heart: | compile | 14m 14s | branch-2.10 passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | compile | 11m 22s | branch-2.10 passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +1 :green_heart: | checkstyle | 0m 35s | branch-2.10 passed |
| +1 :green_heart: | mvnsite | 1m 14s | branch-2.10 passed |
| +1 :green_heart: | javadoc | 1m 14s | branch-2.10 passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javadoc | 0m 58s | branch-2.10 passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +0 :ok: | spotbugs | 6m 19s | Both FindBugs and SpotBugs are enabled,
using SpotBugs. |
| -1 :x: | spotbugs | 2m 2s | hadoop-common-project/hadoop-common in
branch-2.10 has 2 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 45s | the patch passed |
| +1 :green_heart: | compile | 13m 25s | the patch passed with JDK Azul
Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javac | 13m 25s | the patch passed |
| +1 :green_heart: | compile | 11m 19s | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +1 :green_heart: | javac | 11m 19s | the patch passed |
| -0 :warning: | checkstyle | 0m 35s |
hadoop-common-project/hadoop-common: The patch generated 3 new + 20 unchanged -
2 fixed = 23 total (was 22) |
| +1 :green_heart: | mvnsite | 1m 14s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 1m 12s | the patch passed with JDK Azul
Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javadoc | 0m 58s | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +1 :green_heart: | spotbugs | 2m 11s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 8m 57s | hadoop-common in the patch failed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate
ASF License warnings. |
| | | 107m 20s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.log.TestLogLevel |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2999/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2999 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle |
| uname | Linux 0cae3851ce23 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-2.10 / 77d9c6d |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| Multi-JDK versions | /usr/lib/jvm/zulu-7-amd64:Azul Systems,
Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| spotbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2999/1/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2999/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2999/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2999/1/testReport/ |
| Max. process+thread count | 1518 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2999/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 594898)
Time Spent: 1.5h (was: 1h 20m)
> Allow ProtobufRpcEngine to be extensible
> ----------------------------------------
>
> Key: HADOOP-17680
> URL: https://issues.apache.org/jira/browse/HADOOP-17680
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Hector Sandoval Chaverri
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The ProtobufRpcEngine class doesn't allow for new RpcEngine implementations
> to extend some of its inner classes (e.g. Invoker and
> Server.ProtoBufRpcInvoker). Also, some of its methods are long enough such
> that overriding them would result in a lot of code duplication (e.g.
> Invoker#invoke and Server.ProtoBufRpcInvoker#call).
> When implementing a new RpcEngine, it would be helpful to reuse most of the
> code already in ProtobufRpcEngine. This would allow new fields to be added to
> the RPC header or message with minimal code changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
