[
https://issues.apache.org/jira/browse/HADOOP-17680?focusedWorklogId=598059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598059
]
ASF GitHub Bot logged work on HADOOP-17680:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 18:28
Start Date: 17/May/21 18:28
Worklog Time Spent: 10m
Work Description: jojochuang closed pull request #2905:
URL: https://github.com/apache/hadoop/pull/2905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 598059)
Time Spent: 2h 10m (was: 2h)
> Allow ProtobufRpcEngine to be extensible
> ----------------------------------------
>
> Key: HADOOP-17680
> URL: https://issues.apache.org/jira/browse/HADOOP-17680
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Reporter: Hector Sandoval Chaverri
> Assignee: Hector Sandoval Chaverri
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.1, 3.4.0, 3.1.5, 2.10.2, 3.2.3
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The ProtobufRpcEngine class doesn't allow for new RpcEngine implementations
> to extend some of its inner classes (e.g. Invoker and
> Server.ProtoBufRpcInvoker). Also, some of its methods are long enough such
> that overriding them would result in a lot of code duplication (e.g.
> Invoker#invoke and Server.ProtoBufRpcInvoker#call).
> When implementing a new RpcEngine, it would be helpful to reuse most of the
> code already in ProtobufRpcEngine. This would allow new fields to be added to
> the RPC header or message with minimal code changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
