bogthe commented on a change in pull request #2689:
URL: https://github.com/apache/hadoop/pull/2689#discussion_r631831509
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardConcurrentOps.java
##########
@@ -65,6 +70,12 @@ protected Configuration createConfiguration() {
return conf;
}
+ @Override
+ public void setup() throws Exception {
+ super.setup();
+ assumeFilesystemHasMetadatastore(getFileSystem());
+ }
+
Review comment:
With the new checks added in `AbstractS3ATestBase` this looks obsolete
since the same logic is happening in parent `setup` method:
```
if (isS3GuardRequired()) {
downgradeIfUnguarded(fs);
}
```
Not that important tho since hopefully s3 guard will be removed 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
