[
https://issues.apache.org/jira/browse/HADOOP-17520?focusedWorklogId=596136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596136
]
ASF GitHub Bot logged work on HADOOP-17520:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/21 14:02
Start Date: 13/May/21 14:02
Worklog Time Spent: 10m
Work Description: bogthe commented on a change in pull request #2689:
URL: https://github.com/apache/hadoop/pull/2689#discussion_r631831509
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardConcurrentOps.java
##########
@@ -65,6 +70,12 @@ protected Configuration createConfiguration() {
return conf;
}
+ @Override
+ public void setup() throws Exception {
+ super.setup();
+ assumeFilesystemHasMetadatastore(getFileSystem());
+ }
+
Review comment:
With the new checks added in `AbstractS3ATestBase` this looks obsolete
since the same logic is happening in parent `setup` method:
```
if (isS3GuardRequired()) {
downgradeIfUnguarded(fs);
}
```
Not that important tho since hopefully s3 guard will be removed 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 596136)
Time Spent: 1h (was: 50m)
> S3A to downgraded to unguarded if the DDB table cannot be found
> ---------------------------------------------------------------
>
> Key: HADOOP-17520
> URL: https://issues.apache.org/jira/browse/HADOOP-17520
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0, 3.1.4, 3.2.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> when an FNFE is raised in s3guard init, catch and downgrade to NullMetastore
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
