[jira] [Commented] (HADOOP-7688) When a servlet filter throws an exception in init(..), the Jetty server failed silently.

[Uma Maheswara Rao G (Commented) (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142105#comment-13142105
 ] 

Uma Maheswara Rao G commented on HADOOP-7688:
---------------------------------------------

Thanks Nicholas for taking a look!

 Did you see my first comment? 
{code}
Handler[] handlers = webServer.getHandlers();
    for (int i = 0; i < handlers.length; i++) {
      if(false == handlers[i].isRunning()){
        throw new IOException("Problem starting http server");
      }
    }{code}
Since we can access the webServer directly, why con't we check the handlers 
(see the code snippet above).
 Http server will set the contextHandlers to Server.

{code}
final String appDir = getWebAppsPath();
    ContextHandlerCollection contexts = new ContextHandlerCollection();
    webServer.setHandler(contexts);
{code}

 So, if any of the Filter init fails, the corresponding context will fail to 
start.
 
Are you seeing any issue with this?

With your proposed one, we need to create HTTPConnection explicitely and check.

Thanks,
Uma



                
> When a servlet filter throws an exception in init(..), the Jetty server 
> failed silently. 
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7688
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7688
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Uma Maheswara Rao G
>         Attachments: filter-init-exception-test.patch, 
> org.apache.hadoop.http.TestServletFilter-output.txt
>
>
> When a servlet filter throws a ServletException in init(..), the exception is 
> logged by Jetty but not re-throws to the caller.  As a result, the Jetty 
> server failed silently.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira