zhengchenyu commented on a change in pull request #3105:
URL: https://github.com/apache/hadoop/pull/3105#discussion_r652427364
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -2394,16 +2396,22 @@ void transferBlock(ExtendedBlock block, DatanodeInfo[]
xferTargets,
int numTargets = xferTargets.length;
if (numTargets > 0) {
- final String xferTargetsString =
- StringUtils.join(" ", Arrays.asList(xferTargets));
- LOG.info("{} Starting thread to transfer {} to {}", bpReg, block,
- xferTargetsString);
+ if (transferringBlock.contains(block)) {
+ LOG.warn(
Review comment:
Just like I said, when datanode's io is busy, DataTransfer will stuck
for long time, the pendingReconstructBlock will timeout. Then a duplicated
DataTransfer thread for same block will start, and the duplicated DataTransfer
thread will make io busier. In fact, we found our datanode's io is busy for
long time util we restart datanode. So I think we should avoid the duplicated
DataTransfer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
