zhengchenyu commented on a change in pull request #3105:
URL: https://github.com/apache/hadoop/pull/3105#discussion_r652445254
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -2646,6 +2655,7 @@ public void run() {
} catch (Throwable t) {
LOG.error("Failed to transfer block {}", b, t);
} finally {
+ transferringBlock.remove(b);
Review comment:
I don't catch you advice, transferringBlock.add and
transferringBlock.remove could be only called DataTransfer.run, I think won't
leave garbage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
