[
https://issues.apache.org/jira/browse/HADOOP-17250?focusedWorklogId=613278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613278
]
ASF GitHub Bot logged work on HADOOP-17250:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/21 08:10
Start Date: 22/Jun/21 08:10
Worklog Time Spent: 10m
Work Description: mukund-thakur commented on a change in pull request
#3110:
URL: https://github.com/apache/hadoop/pull/3110#discussion_r655109352
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java
##########
@@ -878,6 +884,10 @@ public SASTokenProvider getSASTokenProvider() throws
AzureBlobFileSystemExceptio
}
}
+ public int getReadAheadRange() {
+ return this.readAheadRange;
Review comment:
Yes but it is just a getter and consistent with other getters.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java
##########
@@ -62,6 +62,8 @@
public static final boolean DEFAULT_OPTIMIZE_FOOTER_READ = false;
public static final boolean DEFAULT_ALWAYS_READ_BUFFER_SIZE = false;
public static final int DEFAULT_READ_AHEAD_BLOCK_SIZE = 4 * ONE_MB;
+ // Default value of read ahead range.
+ public static final int DEFAULT_READ_AHEAD_RANGE = 64 * ONE_KB; // 64 KB
Review comment:
Ok. This as per suggestion from Rajesh after his experiments.
https://github.com/apache/hadoop/pull/2307#issuecomment-694159756
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamContext.java
##########
@@ -115,6 +124,8 @@ public AbfsInputStreamContext build() {
readAheadBlockSize = readBufferSize;
}
// Validation of parameters to be done here.
+ Preconditions.checkArgument(readAheadRange > 0,
Review comment:
It doesn't makes sense right? If set to 0 means disabling readAhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 613278)
Time Spent: 2h 50m (was: 2h 40m)
> ABFS: Random read perf improvement
> ----------------------------------
>
> Key: HADOOP-17250
> URL: https://issues.apache.org/jira/browse/HADOOP-17250
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.0
> Reporter: Sneha Vijayarajan
> Assignee: Mukund Thakur
> Priority: Major
> Labels: abfsactive, pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Random read if marginally read ahead was seen to improve perf for a TPCH
> query.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
