[
https://issues.apache.org/jira/browse/HADOOP-17250?focusedWorklogId=618453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618453
]
ASF GitHub Bot logged work on HADOOP-17250:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/21 20:27
Start Date: 04/Jul/21 20:27
Worklog Time Spent: 10m
Work Description: snvijaya commented on a change in pull request #3110:
URL: https://github.com/apache/hadoop/pull/3110#discussion_r663552686
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -207,6 +215,28 @@ public synchronized int read(final byte[] b, final int
off, final int len) throw
}
incrementReadOps();
do {
+
+ // limit is the maximum amount of data present in buffer.
+ // fCursor is the current file pointer. Thus maximum we can
+ // go back and read from buffer is fCursor - limit.
+ // There maybe case that we read less than requested data.
+ long bytesPresentInBuffer = fCursor - limit;
Review comment:
Rename bytesPresentInBuffer to filePosAtStartOfBuffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 618453)
Time Spent: 4h 10m (was: 4h)
> ABFS: Random read perf improvement
> ----------------------------------
>
> Key: HADOOP-17250
> URL: https://issues.apache.org/jira/browse/HADOOP-17250
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.0
> Reporter: Sneha Vijayarajan
> Assignee: Mukund Thakur
> Priority: Major
> Labels: abfsactive, pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Random read if marginally read ahead was seen to improve perf for a TPCH
> query.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]