[
https://issues.apache.org/jira/browse/HADOOP-17290?focusedWorklogId=615799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615799
]
ASF GitHub Bot logged work on HADOOP-17290:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/21 20:10
Start Date: 28/Jun/21 20:10
Worklog Time Spent: 10m
Work Description: sumangala-patki commented on a change in pull request
#2520:
URL: https://github.com/apache/hadoop/pull/2520#discussion_r660084233
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java
##########
@@ -221,17 +226,27 @@ private void completeExecute() throws
AzureBlobFileSystemException {
LOG.trace("{} REST operation complete", operationType);
}
+ private void updateClientRequestHeader(AbfsHttpOperation httpOperation,
+ TracingContext tracingContext) {
+ tracingContext.generateClientRequestId();
+ httpOperation.getConnection()
+ .setRequestProperty(HttpHeaderConfigurations.X_MS_CLIENT_REQUEST_ID,
+ tracingContext.constructHeader());
Review comment:
- constructHeader() may be called simply to display IDs, in which case
it should not regenerate new clientReqId each time
- callee setting it would mean adding code to all methods to call this, and
retry case would not be handled
Can be done internally within TC: have a generateClientRequestId function to
create guid, and call it in constructor as well as the setRetryCount which is
invoked per retry. However, had avoided this since we are populating ID
variables only as and when they pass through the corresponding ABFS layers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 615799)
Time Spent: 6h 40m (was: 6.5h)
> ABFS: Add Identifiers to Client Request Header
> ----------------------------------------------
>
> Key: HADOOP-17290
> URL: https://issues.apache.org/jira/browse/HADOOP-17290
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.0
> Reporter: Sumangala Patki
> Assignee: Sumangala Patki
> Priority: Major
> Labels: abfsactive, pull-request-available
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Adding unique values to the client request header to assist in correlating
> requests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
