steveloughran commented on a change in pull request #2706:
URL: https://github.com/apache/hadoop/pull/2706#discussion_r672613441
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java
##########
@@ -389,8 +397,10 @@ public void close() throws IOException {
// PUT the final block
if (hasBlock &&
(block.hasData() || multiPartUpload.getPartsSubmitted() == 0)) {
- //send last part
- uploadCurrentBlock();
+ // send last part and set the value of isLastPart to true in case of
+ // CSE being enabled, since we are sure it is last part as parts
+ // are being uploaded serially in CSE.
+ uploadCurrentBlock(isCSEEnabled);
Review comment:
good point. Looking at source there's no indication this is bad news if
other uploads are in progress, and it would simplify code.
why not set it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
