steveloughran commented on a change in pull request #2706:
URL: https://github.com/apache/hadoop/pull/2706#discussion_r693398280
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -420,7 +420,12 @@ private Constants() {
"fs.s3a.multipart.purge.age";
public static final long DEFAULT_PURGE_EXISTING_MULTIPART_AGE = 86400;
- // s3 server-side encryption, see S3AEncryptionMethods for valid options
+ /**
+ * s3 server-side encryption or s3 client side encryption method, see
Review comment:
having two was too complex. as for a single name and deprecating the
other -yes that's a great idea! we haven't shipped yet, so if you can add a
patch there it'd be welcome.
(FWIW, in my local test setups i will stay on the old setting so tests on
older branches still work. changing a config name is tricky, even with the
deprecation mechanism)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
