[
https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152560#comment-13152560
]
John Lee commented on HADOOP-7833:
----------------------------------
In response to:
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
This patch does not have any new or modified tests because it was modifying a
findbugs filter file. It was tested by running mvn compile findbugs:findbugs in
the hadoop-common-project sub-directory and I verified by examining
hadoop-common/target/findbugsXml.xml file for the absence of any
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos related warnings. Additionally,
this build received a +1 findbugs indicating the absence of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos related warnings.
The -1 javadocs is an issue which is unrelated to this patch, as no Java code
was updated.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates
> findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class
> in the generated class
> ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a
> serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable
> class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of
> org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
