[ 
https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154017#comment-13154017
 ] 

Hudson commented on HADOOP-7833:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1370 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1370/])
    HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed 
by John Lee.

suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml

                
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates 
> findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7833
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7833
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: John Lee
>            Assignee: John Lee
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class 
> in the generated class 
> ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a 
> serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable 
> class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> +    <Match>
> +      <!-- protobuf generated code -->
> +      <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> +    </Match>
> which will exclude all inner classes of 
> org.apache.hadoop.ipc.protobuf.HadoopRpcProtos

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to