mikedias commented on a change in pull request #2706:
URL: https://github.com/apache/hadoop/pull/2706#discussion_r693317652
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -420,7 +420,12 @@ private Constants() {
"fs.s3a.multipart.purge.age";
public static final long DEFAULT_PURGE_EXISTING_MULTIPART_AGE = 86400;
- // s3 server-side encryption, see S3AEncryptionMethods for valid options
+ /**
+ * s3 server-side encryption or s3 client side encryption method, see
Review comment:
Hi, apologies if this had been discussed before but wouldn't be better
to define the client-side encryption in a property called
`fs.s3a.client-side-encryption-algorithm`? Or perhaps deprecate the current
property and move to just `fs.s3a.encryption-algorithm`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
