[
https://issues.apache.org/jira/browse/HADOOP-17947?focusedWorklogId=658887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658887
]
ASF GitHub Bot logged work on HADOOP-17947:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/21 11:28
Start Date: 01/Oct/21 11:28
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #3505:
URL: https://github.com/apache/hadoop/pull/3505#issuecomment-932147785
If we are going to change the javadocs, maybe make clear this is a guava
replacement and what guarantees we offer (none). Here's my draft
```java
/**
* Annotates a program element that exists, or is more widely visible than
* otherwise necessary, for the benefits of testability.
* More specifically <i>testability within the hadoop-* modules</i>.
* This gives the implicit scope and stability of:
* <pre>
* @InterfaceAudience.Private
* @InterfaceStability.Unstable
* </pre>
* If external modules need to access/override these methods, then
* they MUST be rescoped as public/limited private.
*/
```
Now, should we actually move this to the package
`org.apache.hadoop.classification` in the module `hadoop-annotations`? It is a
classification, after all. I think from a consistency perspective, it makes
sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 658887)
Time Spent: 3h 10m (was: 3h)
> Provide alternative to Guava VisibleForTesting in Hadoop common
> ---------------------------------------------------------------
>
> Key: HADOOP-17947
> URL: https://issues.apache.org/jira/browse/HADOOP-17947
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> In an attempt to reduce the dependency on Guava, we should remove
> VisibleForTesting annotation usages as it has very high usage in our
> codebase. This Jira is to provide Hadoop's own alternative and use it in
> hadoop-common-project modules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
