[
https://issues.apache.org/jira/browse/HADOOP-17947?focusedWorklogId=659413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659413
]
ASF GitHub Bot logged work on HADOOP-17947:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/21 06:10
Start Date: 04/Oct/21 06:10
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #3505:
URL: https://github.com/apache/hadoop/pull/3505#issuecomment-933171989
> Adjust to the VFT in Guava, we may want to annotate it with the following
annotations.
>
> ```
> @Retention(RetentionPolicy.CLASS)
> @Target({ElementType.TYPE, ElementType.METHOD})
> @Documented
> ```
Thanks @tasanuma. I tried to adjust it to the one defined here
https://github.com/google/guava/blob/master/guava/src/com/google/common/annotations/VisibleForTesting.java
But now I see that
[GwtCompatible](https://github.com/google/guava/blob/master/guava/src/com/google/common/annotations/GwtCompatible.java)
annotation itself has the Retention and Target annotations so they should be
applied to VFT as well. Let me make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 659413)
Time Spent: 4h 10m (was: 4h)
> Provide alternative to Guava VisibleForTesting in Hadoop common
> ---------------------------------------------------------------
>
> Key: HADOOP-17947
> URL: https://issues.apache.org/jira/browse/HADOOP-17947
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> In an attempt to reduce the dependency on Guava, we should remove
> VisibleForTesting annotation usages as it has very high usage in our
> codebase. This Jira is to provide Hadoop's own alternative and use it in
> hadoop-common-project modules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
