virajjasani commented on pull request #3503: URL: https://github.com/apache/hadoop/pull/3503#issuecomment-934579871
> Is there a need to introduce a new dependency `restrict-imports-enforcer-rule` ? Hadoop repo used checkStyle import configurations to guard against `IllegalImport` including `illegalPkgs` and `illegalClasses`. > > Either way, we should have a single interface to define the list of imports. @amahussein We are already using this dependency in parent pom. Also, even though checkstyle rule fails, we can't prevent someone from using this import. With this dependency, the build will fail if someone uses this dependency in hadoop-common modules. The eventual goal is to remove project level dependencies and put it only in parent pom as part of final PR. This is what we have followed in previous commits as well. For instance, #3087 and #3049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
