amahussein commented on pull request #3503: URL: https://github.com/apache/hadoop/pull/3503#issuecomment-934635623
> > On the other hand,Pushing those changes after a major milestone would mean only one Jira and one PR (i.e., HADOOP-XYZ: migrating banned imports to use restrict-imports-enforcer-rule). > > IMHO the problem here is that if someone has already pushed a couple of commits with illegal imports, then we will have to take care of such individual modules as well, it's kind of rework right? Not really, unless the reviewer proceeds with merging the changes ignoring the checkStyle errors, which it is not supposed to happen. Even if we move forward with pushing the pom changes, we still have the same issue with guava classes defined in checkstyle.xml Anyway, since #3087 and #3049 are already in, then the way to move forward is 1- to proceed with this PR; 2- to file a new jira to migrate `checkStyle.illegalImports` to the parent pom file. For sake of coherence and consistency, this jira has to be merged before any further changes to bannedImports in all pom files. Thanks @virajjasani for the efforts you put into this. Great job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
