[
https://issues.apache.org/jira/browse/HADOOP-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160222#comment-13160222
]
Suresh Srinivas commented on HADOOP-7862:
-----------------------------------------
Comments:
# Rpc.RPC_BUILTIN what is this? Can this be described better
# ProtobufRpcEngine.java
#* Make clientProtocolVersion and protocolName final. There are other members
that could be made final as well.
#* Indentation of ProtoBugRpcInvoker is incorrect
#* Please add javadoc to ProtobufRpcInvoker
// Note the protocol name and version annotations are not declared
// on the declaring class since the declaring class is "BlockingInterface
// Hence we simply use the protocol class used to create the proxy.
// For PB this may limit the use of mixins.
# ProtocolProxy.java
# Several places the lines are beyond 80 chars and in some cases javadoc
parameter names do not match the parameter names in the method declaration.
# Remote System.out.println() at several places
> Move the support for multiple protocols to lower layer so that Writable, PB
> and Avro can all use it
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7862
> URL: https://issues.apache.org/jira/browse/HADOOP-7862
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: mulRpc2-common.patch, mulRpc2.patch, mulRpc3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
