[
https://issues.apache.org/jira/browse/HADOOP-17970?focusedWorklogId=667181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667181
]
ASF GitHub Bot logged work on HADOOP-17970:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 17:56
Start Date: 19/Oct/21 17:56
Worklog Time Spent: 10m
Work Description: amahussein opened a new pull request #3566:
URL: https://github.com/apache/hadoop/pull/3566
### Description of PR
Replace `guava.Preconditions` in folder `hadoop-hdfs-project` with
`hadoop.util.Preconditions`
### How was this patch tested?
Ran the tests locally
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17970. Your PR title ...')?
- [X] There were 4 positions calling `checkPositionIndex`. Since there were
only 4 occurrences I preferred to inline them in the code. The tradeoff is a
slight change of behavior as guava.Preconditions.checkPositionIndex may throw
`IllegalArgumentException`, while the inlined version only throws
`IndexOutOfBoundsException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 667181)
Remaining Estimate: 0h
Time Spent: 10m
> unguava: remove Preconditions from hdfs-projects module
> -------------------------------------------------------
>
> Key: HADOOP-17970
> URL: https://issues.apache.org/jira/browse/HADOOP-17970
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Replace guava Preconditions by internal implementations that rely on java8+
> APIs in the hadoop.util for all modules in hadoop-hdfs-project
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
