9uapaw commented on a change in pull request #3551:
URL: https://github.com/apache/hadoop/pull/3551#discussion_r734646153
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/QueuePath.java
##########
@@ -51,6 +51,13 @@ public QueuePath(String parent, String leaf) {
this.leaf = leaf;
}
+ public static QueuePath createFrom(CSQueue parent, String queueName) {
Review comment:
This is a subjective opinion, but I think we should not expose
heavyweight internal classes to QueuePath just to get a string. In order to
test this very simple factory method, one would need to create a mocked queue,
which is a needless burden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
