9uapaw commented on a change in pull request #3551:
URL: https://github.com/apache/hadoop/pull/3551#discussion_r735611654
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
##########
@@ -174,14 +155,21 @@ public AbstractCSQueue(CapacitySchedulerContext cs,
cs.getConfiguration().getEnableUserMetrics(), configuration);
usageTracker = new CSQueueUsageTracker(metrics);
this.csContext = cs;
- this.minimumAllocation = csContext.getMinimumResourceCapability();
+ this.queueAllocationSettings = new QueueAllocationSettings(csContext);
queueEntity = new PrivilegedEntity(EntityType.QUEUE, getQueuePath());
queueCapacities = new QueueCapacities(parent == null);
ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
readLock = lock.readLock();
writeLock = lock.writeLock();
}
+ public static QueuePath createQueuePath(CSQueue parent, String queueName) {
Review comment:
Nit: Is it appropriate to use a public visibility here? It seems more
like a private static helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
