szilard-nemeth commented on pull request #3570: URL: https://github.com/apache/hadoop/pull/3570#issuecomment-952903203
Thanks @9uapaw for sharing your opinion. By checking the code of TestCapacitySchedulerQueueACLs, IMHO that class is more heavy and does the following: - Sets up queue hierarchies - Mocks QueueManager and CSQueue objects - Mocks UGI - Utilizies MockRM and uses a real instance of CapacityScheduler The point of this class is to test the behavior of the method: org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler#checkAccess My new test class (TestCapacitySchedulerConfiguration) is much lightweight and its purpose is to test the CapacitySchedulerConfiguration. The only reason it contains just ACL tests because there were no tests for this class, which is pretty much disappointing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
