shuzirra commented on pull request #3570: URL: https://github.com/apache/hadoop/pull/3570#issuecomment-952977232
To my mind, TestCapacitySchedulerQueueACLs should have testcases which test the functionality of ACLs, like inheritance, groups / user based matching, etc. While the TestCapacitySchedulerConfiguration should test the configuration part, like parsing of different markups of configuration, defaults etc. So I think BOTH tests have merit, and the TestCapacitySchedulerConfiguration class should be extended with other tests, which test the configuration parsing and evaluation. However I would add a few more testcase where we parse actual data, where we set user and group as well, since now wer only tests cases where we assert for empty configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
