tomscut commented on a change in pull request #3596:
URL: https://github.com/apache/hadoop/pull/3596#discussion_r744070877
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
##########
@@ -394,6 +395,23 @@ public void testEnableParallelLoadAfterReconfigured()
assertEquals(true, FSImageFormatProtobuf.getEnableParallelLoad());
}
+ @Test
+ public void testEnableSlowNodesParametersAfterReconfigured()
+ throws ReconfigurationException {
+ final NameNode nameNode = cluster.getNameNode();
+ final DatanodeManager datanodeManager = nameNode.namesystem
+ .getBlockManager().getDatanodeManager();
+
+ // By default, avoidSlowDataNodesForRead is false
Review comment:
According to the standard of previous review, a period should be added
after the comment.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
##########
@@ -394,6 +395,23 @@ public void testEnableParallelLoadAfterReconfigured()
assertEquals(true, FSImageFormatProtobuf.getEnableParallelLoad());
}
+ @Test
+ public void testEnableSlowNodesParametersAfterReconfigured()
+ throws ReconfigurationException {
+ final NameNode nameNode = cluster.getNameNode();
+ final DatanodeManager datanodeManager = nameNode.namesystem
+ .getBlockManager().getDatanodeManager();
+
+ // By default, avoidSlowDataNodesForRead is false
+ assertEquals(false, datanodeManager.getEnableAvoidSlowDataNodesForRead());
+
+ nameNode.reconfigureProperty(
+ DFS_NAMENODE_AVOID_SLOW_DATANODE_FOR_READ_KEY, Boolean.toString(true));
+
+ // After reconfigured, avoidSlowDataNodesForRead is true
Review comment:
Please add a period after the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
