haiyang1987 commented on a change in pull request #3596:
URL: https://github.com/apache/hadoop/pull/3596#discussion_r745395703
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
> Thanks @tomscut for your comment.
[HDFS-15120](https://issues.apache.org/jira/browse/HDFS-15120) already support
BlockPlacementPolicyDefault#dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled
reconfigurable. But the current way I think is heavy. Do we need to support
alone logic make excludeSlowNodesEnabled reconfigurable？
Hi @tomscut take a deep look at code discovery HDFS-15120, if we don't
update 'dfs.block.replicator.classname',
'dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled' can't support
reconfigurable.
so we need to support alone logic make excludeSlowNodesEnabled
reconfigurable.
Consider create a new issue to solve this problem.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
