aajisaka commented on a change in pull request #3728:
URL: https://github.com/apache/hadoop/pull/3728#discussion_r762127560
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/util/LeveldbUtils.java
##########
@@ -203,6 +207,8 @@ public static DB loadOrRepairLevelDb(JniDBFactory factory,
Path dbPath, Options
File dbFile = new File(dbPath.toString());
File dbBackupPath = new File(
dbPath.toString() + BACKUP_EXT + Time.monotonicNow());
+ LOG.warn("Incurred exception while loading LevelDb database. Backing " +
+ "up at "+ dbBackupPath, ioe);
Review comment:
Would you use slf4j placeholder (`{}`) for logging? It enables
lazy-evaluation and improve performance especially in debug log.
http://www.slf4j.org/faq.html#logging_performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
