tomscut commented on pull request #3839: URL: https://github.com/apache/hadoop/pull/3839#issuecomment-1008568017
> Thanks @tomscut for your information. It makes sense to me. I concerned why [HDFS-14042](https://issues.apache.org/jira/browse/HDFS-14042) not fix completely, any other corner case? Thanks @Hexiaoqiao for your comments. NPE has been fixed by [HDFS-14042](https://issues.apache.org/jira/browse/HDFS-14042). IMO, it is a safer way to keep these two operations (`stats.subtract() `and `stats.add()`) transactional in case of any other potential exceptions. What do you think of this? This has no effect on the original logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
