Hexiaoqiao commented on pull request #3839: URL: https://github.com/apache/hadoop/pull/3839#issuecomment-1008573988
> IMO, it is a safer way to keep these two operations (stats.subtract() and stats.add()) transactional in case of any other potential exceptions. Totally agree with that. Not sure why/where throw NPE after HDFS-14042. I think add another new unit test to cover will be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
