steveloughran commented on a change in pull request #3499:
URL: https://github.com/apache/hadoop/pull/3499#discussion_r783306088
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java
##########
@@ -112,6 +117,21 @@ public void testVectoredReadAndReadFully() throws
Exception {
}
}
+
+ @Test
+ public void testVectoredReadBigFile() throws Exception {
+ FileSystem fs = getFileSystem();
+ List<FileRange> fileRanges = new ArrayList<>();
+ fileRanges.add(new FileRangeImpl(1293, 25837));
+ try (FSDataInputStream in = fs.open(path(VECTORED_READ_FILE_1MB_NAME))) {
Review comment:
can you use openFile here? just to make sure that codepath is happy
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java
##########
@@ -35,6 +35,9 @@
public static final int DATASET_LEN = 1024;
private static final byte[] DATASET = ContractTestUtils.dataset(DATASET_LEN,
'a', 32);
private static final String VECTORED_READ_FILE_NAME = "vectored_file.txt";
+ private static final String VECTORED_READ_FILE_1MB_NAME =
"vectored_file_1M.txt";
+ private static final byte[] DATASET_MB = ContractTestUtils.dataset(1024 *
1024, 'a', 256);
Review comment:
are we OK with this not being in a scale test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
