steveloughran commented on a change in pull request #3499:
URL: https://github.com/apache/hadoop/pull/3499#discussion_r783309705
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
##########
@@ -887,18 +887,22 @@ private void updateOriginalRange(FileRange child,
child.getOffset(), child.getLength(),
combinedFileRange.getOffset(), combinedFileRange.getLength());
ByteBuffer childBuffer = sliceTo(combinedBuffer,
combinedFileRange.getOffset(), child);
child.getData().complete(childBuffer);
- LOG.trace("End Filling original range ");
+ LOG.trace("End Filling original range [{}, {}) from combined range [{},
{}) ",
+ child.getOffset(), child.getLength(),
combinedFileRange.getOffset(), combinedFileRange.getLength());
}
/**
* Validates range parameters.
- * @param range
- * @throws EOFException
+ * @param range requested range.
+ * @throws EOFException end of file exception.
*/
private void validateRangeRequest(FileRange range) throws EOFException {
VectoredReadUtils.validateRangeRequest(range);
if(range.getOffset() + range.getLength() > contentLength) {
- throw new EOFException("Requested range is beyond EOF");
+ LOG.error("Requested range [{}, {}) is beyond EOF",
Review comment:
why log at error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
